Skip to content

Comments

Polish helm related docs#6946

Merged
sijie merged 4 commits intoapache:masterfrom
Huanli-Meng:Polish-helm-related-docs
May 18, 2020
Merged

Polish helm related docs#6946
sijie merged 4 commits intoapache:masterfrom
Huanli-Meng:Polish-helm-related-docs

Conversation

@Huanli-Meng
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (docs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Huanli-Meng
Copy link
Contributor Author

@Anonymitaet, please help review.

@sijie sijie added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. component/website labels May 18, 2020
@sijie sijie added this to the 2.6.0 milestone May 18, 2020
@sijie sijie merged commit 1be8461 into apache:master May 18, 2020
@lukestephenson
Copy link
Contributor

Hello. I'm not sure if it is related to this PR, but in 2.5.2 of the docs, the section to "Run Pulsar in Kubernetes" has disappeared from "Get started".
image

Compare this to the previous version 2.5.1 and it is present
image

@Huanli-Meng
Copy link
Contributor Author

@lukestephenson , Thanks for your feedback. I will check the doc and fix it as soon as possible.

Huanli-Meng added a commit to Huanli-Meng/pulsar that referenced this pull request May 27, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants