Fix the flaky function test.#7057
Merged
srkukarni merged 3 commits intoapache:masterfrom May 28, 2020
Merged
Conversation
Contributor
|
@srkukarni the test should also be deleted flaky tests https://github.com/apache/pulsar/blob/master/.github/workflows/ci-unit-flaky.yaml#L84 and removed from: https://github.com/apache/pulsar/blob/master/.github/workflows/ci-unit-broker.yml#L128 a list of tests in pulsar-broker that does NOT run |
Contributor
Author
|
@jerrypeng done |
jerrypeng
approved these changes
May 27, 2020
315157973
pushed a commit
to 315157973/pulsar
that referenced
this pull request
May 29, 2020
* Fix the flaky function test. * Add another missing path * Removed the test from flaky tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
* Fix the flaky function test. * Add another missing path * Removed the test from flaky tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
* Fix the flaky function test. * Add another missing path * Removed the test from flaky tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
* Fix the flaky function test. * Add another missing path * Removed the test from flaky tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Fix the flaky function test. * Add another missing path * Removed the test from flaky tests Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Since we don't wait for stop/restart to actually 'complete' serverside, our delete request could get out of date when it reaches the server side. Thus retry it if we get a PulsarAdminException.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation