Skip to content

Fix the flaky function test.#7057

Merged
srkukarni merged 3 commits intoapache:masterfrom
srkukarni:fix_flakiness
May 28, 2020
Merged

Fix the flaky function test.#7057
srkukarni merged 3 commits intoapache:masterfrom
srkukarni:fix_flakiness

Conversation

@srkukarni
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Since we don't wait for stop/restart to actually 'complete' serverside, our delete request could get out of date when it reaches the server side. Thus retry it if we get a PulsarAdminException.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@jerrypeng
Copy link
Contributor

@srkukarni the test should also be deleted flaky tests

https://github.com/apache/pulsar/blob/master/.github/workflows/ci-unit-flaky.yaml#L84

and removed from:

https://github.com/apache/pulsar/blob/master/.github/workflows/ci-unit-broker.yml#L128

a list of tests in pulsar-broker that does NOT run

@srkukarni
Copy link
Contributor Author

@jerrypeng done

@srkukarni srkukarni merged commit afd3296 into apache:master May 28, 2020
@srkukarni srkukarni deleted the fix_flakiness branch May 28, 2020 02:29
315157973 pushed a commit to 315157973/pulsar that referenced this pull request May 29, 2020
* Fix the flaky function test.

* Add another missing path

* Removed the test from flaky tests

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
* Fix the flaky function test.

* Add another missing path

* Removed the test from flaky tests

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
* Fix the flaky function test.

* Add another missing path

* Removed the test from flaky tests

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 12, 2020
* Fix the flaky function test.

* Add another missing path

* Removed the test from flaky tests

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
* Fix the flaky function test.

* Add another missing path

* Removed the test from flaky tests

Co-authored-by: Sanjeev Kulkarni <sanjeevk@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants