Skip to content

[doc] Clarify the impact of batch message in key_shared subscription#7175

Merged
codelipenghui merged 3 commits intoapache:masterfrom
codelipenghui:penghui/fix-7121
Jun 5, 2020
Merged

[doc] Clarify the impact of batch message in key_shared subscription#7175
codelipenghui merged 3 commits intoapache:masterfrom
codelipenghui:penghui/fix-7121

Conversation

@codelipenghui
Copy link
Contributor

Fixes #7121

Motivation

Following the java example at http://pulsar.apache.org/docs/en/client-libraries-java/#key_shared. The messages sometimes may send to only one consumer if the producer sends the batched messages. It's better to clarify in the doc to introduce the right way to use key_shared subscription.

Modifications

Update Java client documentation.

@codelipenghui codelipenghui self-assigned this Jun 5, 2020
@codelipenghui codelipenghui added this to the 2.6.0 milestone Jun 5, 2020
@codelipenghui
Copy link
Contributor Author

@Huanli-Meng Please help review this PR.

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave my comments, please take a look.

codelipenghui and others added 2 commits June 5, 2020 14:44
Co-authored-by: HuanliMeng <48120384+Huanli-Meng@users.noreply.github.com>
Co-authored-by: HuanliMeng <48120384+Huanli-Meng@users.noreply.github.com>
@codelipenghui codelipenghui added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 5, 2020
@codelipenghui codelipenghui merged commit 958398e into apache:master Jun 5, 2020
@codelipenghui codelipenghui deleted the penghui/fix-7121 branch June 5, 2020 07:05
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this pull request Jul 24, 2020
…pache#7175)

Fixes apache#7121 

### Motivation

Following the java example at http://pulsar.apache.org/docs/en/client-libraries-java/#key_shared. The messages sometimes may send to only one consumer if the producer sends the batched messages. It's better to clarify in the doc to introduce the right way to use key_shared subscription.

### Modifications

Update Java client documentation.
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
…pache#7175)

Fixes apache#7121 

### Motivation

Following the java example at http://pulsar.apache.org/docs/en/client-libraries-java/#key_shared. The messages sometimes may send to only one consumer if the producer sends the batched messages. It's better to clarify in the doc to introduce the right way to use key_shared subscription.

### Modifications

Update Java client documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] Clarify the impact of batch message in key_shared subscription

3 participants