Skip to content

Comments

[Doc]--[python client] negative acks#7263

Merged
codelipenghui merged 1 commit intoapache:masterfrom
Huanli-Meng:negative-ack-to-python
Jun 16, 2020
Merged

[Doc]--[python client] negative acks#7263
codelipenghui merged 1 commit intoapache:masterfrom
Huanli-Meng:negative-ack-to-python

Conversation

@Huanli-Meng
Copy link
Contributor

Motivation

In Pulsar 2.4.0, negative acknowledgement is supported in Python client. But the doc has no such code example.

So this PR is for adding negative ack code example for releases: master--2.4.0.

The doc update is approved in PR: #7148. But the PR fails CI test. So i close that PR and re-create a new PR.

Modifications

Add negative ack code example to python client doc for releases master--2.4.0.

@Huanli-Meng
Copy link
Contributor Author

@jiazhai , the doc updates have been approved through PR: #7148.

because that PR fails CI test and we cannot figure out how to fix it. So i create the original PR and re-create a PR.

Please help approve the PR.

@codelipenghui codelipenghui added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 16, 2020
@codelipenghui codelipenghui added this to the 2.7.0 milestone Jun 16, 2020
@codelipenghui codelipenghui merged commit 71ebb53 into apache:master Jun 16, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
### Motivation

In Pulsar 2.4.0, negative acknowledgement is supported in Python client. But the doc has no such code example. 

So this PR is for adding negative ack code example for releases: master--2.4.0.

The doc update is approved in PR: apache#7148. But the PR fails CI test. So i close that PR and re-create a new PR.



### Modifications

Add negative ack code example to python client doc for releases master--2.4.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants