Skip to content

Comments

[ISSUE #6116] fix the download links for and the sequence of source and sink#7472

Merged
merlimat merged 1 commit intoapache:masterfrom
streamnative:#6116]-fix-the-download-links
Jul 10, 2020
Merged

[ISSUE #6116] fix the download links for and the sequence of source and sink#7472
merlimat merged 1 commit intoapache:masterfrom
streamnative:#6116]-fix-the-download-links

Conversation

@sijia-w
Copy link
Contributor

@sijia-w sijia-w commented Jul 7, 2020

Fix: #6116

Motivation

Fix the issue 6116.

Modifications

Fix the duplicate links for source and link download and put them in alphabetical order.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

longName: 'Apache Cassandra sink',
type: 'Sink',
longName: 'Apache Cassandra source and sink',
type: 'Source and sink',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really curious if this field is used anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked it locally. The links all work well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was not really related to your changes. The type field is not used and maybe it makes sense to remove it in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Thanks so much for your reply.

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat merged commit 02fa64c into apache:master Jul 10, 2020
@merlimat merlimat added this to the 2.7.0 milestone Jul 10, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Co-authored-by: Sijia WANG <sijia@Wangs-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download page has multiple entries for some artifacts

4 participants