[ISSUE #6116] fix the download links for and the sequence of source and sink#7472
Merged
merlimat merged 1 commit intoapache:masterfrom Jul 10, 2020
Merged
Conversation
vzhikserg
reviewed
Jul 7, 2020
| longName: 'Apache Cassandra sink', | ||
| type: 'Sink', | ||
| longName: 'Apache Cassandra source and sink', | ||
| type: 'Source and sink', |
Contributor
There was a problem hiding this comment.
I am really curious if this field is used anywhere.
Contributor
Author
There was a problem hiding this comment.
I have checked it locally. The links all work well.
Contributor
There was a problem hiding this comment.
This comment was not really related to your changes. The type field is not used and maybe it makes sense to remove it in the future
Contributor
Author
There was a problem hiding this comment.
Okay. Thanks so much for your reply.
vzhikserg
approved these changes
Jul 9, 2020
merlimat
approved these changes
Jul 10, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Co-authored-by: Sijia WANG <sijia@Wangs-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #6116
Motivation
Fix the issue 6116.
Modifications
Fix the duplicate links for source and link download and put them in alphabetical order.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation