Avoid pulsar-client-api dependency on txn-common#7511
Merged
merlimat merged 3 commits intoapache:masterfrom Jul 13, 2020
Merged
Avoid pulsar-client-api dependency on txn-common#7511merlimat merged 3 commits intoapache:masterfrom
merlimat merged 3 commits intoapache:masterfrom
Conversation
codelipenghui
approved these changes
Jul 13, 2020
sijie
approved these changes
Jul 13, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Avoid pulsar-client-api dependency on txn-common * Fixed dep in pulsar-client-original * Fixed missing guava dep on jdbc-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-client-apiis meant to be free of dependencies. This is to ensure that:Right now, the
TxnIDclass is defined ontransactions-common, though since it's exposed in API, it should be part ofpulsar-client-api.The current dependency cycle is bringing
pulsar-client-api->transaction-common->protobuf-java-util->gson.