fix: batch source able to be submitted#7659
Merged
srkukarni merged 2 commits intoapache:masterfrom Jul 25, 2020
Merged
Conversation
jerrypeng
added
type/bug
srkukarni
approved these changes
Jul 24, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Jul 25, 2020
* fix: batch source able to be submitted * fix logic Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit ee39e40)
jerrypeng
added a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
Jul 28, 2020
* fix: batch source able to be submitted * fix logic Co-authored-by: Jerry Peng <jerryp@splunk.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* fix: batch source able to be submitted * fix logic Co-authored-by: Jerry Peng <jerryp@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Batch source currently cannot be successfully submitted via Admin API. A server side check rejects it because it doesn't implement the Source interface.
Modifications
Allow sources that implement BatchSource to pass validation