Make bundle REST calls to be async #7776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
codelipenghui,
ivankelly,
jerrypeng,
rdhabalia,
sijie and
srkukarni
merlimat
force-pushed
the
async-web-bundle-ops
branch
from
ad0eb11 to
0d01fc1
Compare
jiazhai
approved these changes
Aug 9, 2020
sijie
approved these changes
Aug 11, 2020
codelipenghui
approved these changes
Aug 12, 2020
Contributor
|
/pulsarbot run-failure-checks |
1 similar comment
Member
|
/pulsarbot run-failure-checks |
Member
|
ping @merlimat Can you merge master code and fix conflict? |
Member
|
ping @merlimat again, Can you merge master code and fix conflict? |
Contributor
|
@merlimat Could you please rebase to the apache/master branch? |
Contributor
|
move to milestone 2.8.0 first |
Contributor
|
@merlimat Could you please rebase to the apache/master branch? |
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
Member
|
Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Several operations that work over bundle are triggering multiple calls, one per bundle, against the broker, to be redirected to other brokers.
Since these HTTP calls are handled synchronously, if there are many bundles in a namespace, it can cause a deadlock in Jetty threads, since 1 call will fan out to make multiple calls to itself.
To avoid that, we need to make sure all the operations regarding bundles are handled asynchronously.