[Issue 7749][chore] Use maven wrapper to lock maven version#7877
Closed
kezhenxu94 wants to merge 1 commit intoapache:masterfrom
kezhenxu94:chore/mvnw
Closed
[Issue 7749][chore] Use maven wrapper to lock maven version#7877kezhenxu94 wants to merge 1 commit intoapache:masterfrom kezhenxu94:chore/mvnw
kezhenxu94 wants to merge 1 commit intoapache:masterfrom
kezhenxu94:chore/mvnw
Conversation
Resolves #7749 - Motivation At the moment, building Pulsar from source codes with maven requires a locally-installed maven, but there are cases that the developers' maven version is not compatible with the one Pulsar uses, this pull request introduces a wrapper of maven, which downloads the specific version of maven on the fly and gets rid of maven versions issues like #7749 - Modifications Add maven wrapper, and modify the doc and CI script to use it - Verifying this change Build from source codes with maven wrapper successfully, and the CI checks should pass
Member
|
/pulsarbot run-failure-checks |
Member
Author
|
Seems the |
Member
Author
|
closing as no response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7749
Motivation
At the moment, building Pulsar from source codes with maven requires a locally-installed maven, but there are cases that the developers' maven version is not compatible with the one Pulsar uses, this pull request introduces a wrapper of maven, which downloads the specific version of maven on the fly and gets rid of maven versions issues like #7749
Modifications
Add maven wrapper, and modify the doc and CI script to use it
Verifying this change
Build from source codes with maven wrapper successfully, and the CI checks should pass
This change is a trivial rework / code cleanup without any test coverage.