[ISSUE 6408] Fix NumberFormatException#8143
Conversation
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
jerrypeng,
jiazhai,
merlimat,
sijie,
srkukarni and
wolfstudy
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/FunctionsImpl.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@315157973, waiting that this is reviewed and accepted, could you provide the "patched" jar files so that I can try to see if it helps? |
Only 3 files have been modified, you can copy them directly to your local. |
|
I use pulsar in the docker and the jar files present contains only .class files so I cannot even update the files directly in the jar files. |
jianyun8023
left a comment
jianyun8023
left a comment
There was a problem hiding this comment.
What I saw here seems to be that the NumberFormatException is run out correctly, and it does not solve the problem that Pulsar Function does not support multi-service Url.
| ServiceURI serviceUri = ServiceURI.create(serviceUrl); | ||
| root = client.target(String.format("%s://%s" | ||
| , serviceUri.getServiceScheme() | ||
| , serviceUri.getServiceHosts()[ThreadLocalRandom.current() | ||
| .nextInt(serviceUri.getServiceHosts().length)])); | ||
|
|
There was a problem hiding this comment.
I have a little doubt. Is this fixed the problem that the pulsar function does not support multi-service URLs?
There was a problem hiding this comment.
I have a little doubt. Is this fixed the problem that the pulsar function does not support multi-service URLs?
Yes, when we create a Function, the Client initiates a request. Since multi-service URLs are not supported here, a NumberFormatException will be thrown.
When you restore this code, then update the jar to the lib, create a Function with cli, you can reproduce the previous bug.
Fixes apache#6408 ### Motivation 1）ExecutionException cannot be cast to org.apache.pulsar.client.admin.PulsarAdminException 2）Client cannot recognize multiple addresses ### Modifications support multiple addresses
6 participants
Fixes #6408
Motivation
1）ExecutionException cannot be cast to org.apache.pulsar.client.admin.PulsarAdminException
2）Client cannot recognize multiple addresses
Modifications
support multiple addresses
Verifying this change
PulsarFunctionPublishTest#testMultipleAddress