[pulsar-io] Add NSQ Source#8250
Conversation
|
The current issue (aside from a general unfamiliarity with maven and best build practices within the project) is that my IDE (vscode) will not offer the automatic actions on testing that it did in my individual checkout. The only solution I've thought to try so far is to issue a It seems to resolve my own dependencies fine. |
|
Turns out I was building against JDK 14. Used Jenv to install JDK 11, correcting a couple of errors and will issue another push. |
|
I believe everything should be in order now. I am unsure why these checks are failing, but they don't seem to be related. Awaiting review. |
|
/pulsarbot run-failure-checks |
|
@flowchartsman Thanks for the great contribution, we will review soon. |
|
@codelipenghui Can you review this? |
|
Pending the review, now is probably a good time to ask about when to add any knobs that the user might want. There are certainly a bunch of NSQ configuration options that could be supplied, this is a pretty bare bones transporter. I am happy to add a few now, though some of them (including auth) would rely on secrets, which I might need some help implementing. |
|
@flowchartsman There are some flaky test that already fixed in master branch, could you please sync with the apache master |
|
I believe I may have issued a rebase incorrectly, I will attempt to resolve |
8364752 to
638352a
Compare
|
@codelipenghui I see some tests still failing—are we good, or do I need to make some more changes? |
Motivation
This PR adds a source representing an NSQ topic to be mirrored to a pulsar topic.
Modifications
With the exception of adding it as a module to
pulsar-io/pom.xml, there are no modifications to existing code.Verifying this change
I need some help with this, since it is adapted from a local, standalone repo, and I am having difficulties getting maven to resolve dependencies for other parts of the Pulsar codebase, which prevents me from testing it properly in situ.
This change added tests and can be verified as follows:
This change is largely based off of the Twitter Firehose example, which tests only its config, and I have written similar tests, as well as an extra for the default channel option. Any guidance on further tests is appreciated.
Does this pull request potentially affect one of the following parts:
N/Z
Documentation
Note: if I have missed any other links to documentation, please mention them in the comments and I will add them.
Further notes