Skip to content

[Issue 8311][pulsar-client-cpp] In C shim, free message ID pointer after hitting callback #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bschofield wants to merge 2 commits into from
Closed

[Issue 8311][pulsar-client-cpp] In C shim, free message ID pointer after hitting callback #8312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2c722
Free message ID pointer after hitting callback.
bschofield Oct 20, 2020
3c7a33e
Avoid nugatory new/delete
bschofield Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pulsar-client-cpp/lib/c/c_Producer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ pulsar_result pulsar_producer_send(pulsar_producer_t *producer, pulsar_message_t
static void handle_producer_send(pulsar::Result result, pulsar::MessageId messageId,
pulsar_send_callback callback, void *ctx) {
if (result == pulsar::ResultOk) {
pulsar_message_id_t *c_message_id = new pulsar_message_id_t;
c_message_id->messageId = messageId;
callback(pulsar_result_Ok, c_message_id, ctx);
pulsar_message_id_t c_message_id;
c_message_id.messageId = messageId;
callback(pulsar_result_Ok, &c_message_id, ctx);
} else {
callback((pulsar_result)result, NULL, ctx);
}
Expand Down