Try to fix flaky test in the InactiveTopicDeleteTest.java#8392
Merged
codelipenghui merged 10 commits intoapache:masterfrom Oct 28, 2020
Merged
Try to fix flaky test in the InactiveTopicDeleteTest.java#8392codelipenghui merged 10 commits intoapache:masterfrom
codelipenghui merged 10 commits intoapache:masterfrom
Conversation
Contributor
Author
|
The second problem has been fixed, the first one I will comment out some code to see what the real error is |
sijie
reviewed
Oct 27, 2020
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 28, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
1）testTopicLevelInActiveTopicApi：The error is caused by `getInactiveTopicPolicies()`, due to the slow startup of the broker, the cache has not been initialized yet. 2)testTopicLevelInactivePolicyUpdateAndClean：We previously updated the event trigger timing of topic-policies. The update is triggered after the event is consumed. Therefore, it is not enough to judge that the policy in the cache is null. We need to sleep and wait for the event to be consumed.
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
1）testTopicLevelInActiveTopicApi：The error is caused by `getInactiveTopicPolicies()`, due to the slow startup of the broker, the cache has not been initialized yet. 2)testTopicLevelInactivePolicyUpdateAndClean：We previously updated the event trigger timing of topic-policies. The update is triggered after the event is consumed. Therefore, it is not enough to judge that the policy in the cache is null. We need to sleep and wait for the event to be consumed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1）testTopicLevelInActiveTopicApi：The error is caused by
getInactiveTopicPolicies(), due to the slow startup of the broker, the cache has not been initialized yet.2)testTopicLevelInactivePolicyUpdateAndClean：We previously updated the event trigger timing of topic-policies. The update is triggered after the event is consumed. Therefore, it is not enough to judge that the policy in the cache is null. We need to sleep and wait for the event to be consumed.