Reorder imports in some packages to conform checkstyle#8556
Merged
codelipenghui merged 2 commits intoapache:masterfrom Nov 14, 2020
Merged
Reorder imports in some packages to conform checkstyle#8556codelipenghui merged 2 commits intoapache:masterfrom
codelipenghui merged 2 commits intoapache:masterfrom
Conversation
Signed-off-by: Renkai <gaelookair@gmail.com>
Signed-off-by: Renkai <gaelookair@gmail.com>
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Nov 13, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
sijie
pushed a commit
that referenced
this pull request
Nov 30, 2020
### Motivation Some packages build fail due to `ImportOrder` check fail by checkstyle. Although these packages are excluded in `suppressions.xml` but still got `ImportOrder` check fail in my environment. ### Modifications Optimize imports for these package by IDEA using the Imports setting mentioned in #8556 1. Remove the blank line between imports. 2. Reorder imports in ascending 3. Remove exclude pacakge in `suppressions.xml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the way, I found a way to set IDEA to optimize imports to automatically conform checkstyle, just set
code style -> Java -> Imports -> Import layoutlike the picture below.