[Transaction] Add the batch size in transaction ack command.#8612
Closed
congbobo184 wants to merge 8 commits intoapache:masterfrom
congbobo184:congbobo184_txn_batch_pendingack_modify
Closed
[Transaction] Add the batch size in transaction ack command.#8612congbobo184 wants to merge 8 commits intoapache:masterfrom congbobo184:congbobo184_txn_batch_pendingack_modify
congbobo184 wants to merge 8 commits intoapache:masterfrom
congbobo184:congbobo184_txn_batch_pendingack_modify
Conversation
codelipenghui
requested changes
Nov 18, 2020
| if (pendingAckHandle == null) { | ||
| return FutureUtil.failedFuture( | ||
| new TransactionConflictException("Broker does't support Transaction pending ack!")); | ||
| new NotAllowedException("Broker does't support Transaction pending ack!")); |
Contributor
There was a problem hiding this comment.
Suggested change
| new NotAllowedException("Broker does't support Transaction pending ack!")); | |
| new NotAllowedException("The transaction is disabled")); |
| optional int32 partition = 3 [default = -1]; | ||
| optional int32 batch_index = 4 [default = -1]; | ||
| repeated int64 ack_set = 5; | ||
| optional uint64 batch_size = 6; |
Contributor
There was a problem hiding this comment.
Suggested change
| optional uint64 batch_size = 6; | |
| optional int32 batch_size = 6; |
int32 is enough for batch size.
| @@ -435,9 +435,6 @@ CompletableFuture<Void> messageAcked(CommandAck ack) { | |||
| private CompletableFuture<Void> individualAckNormal(CommandAck ack, Map<String,Long> properties) { | |||
| List<Position> positionsAcked = new ArrayList<>(); | |||
| List<PositionImpl> checkBatchPositions = null; | |||
Contributor
There was a problem hiding this comment.
This line can be deleted?
Comment on lines
+2421
to
+2422
| cmd = Commands.newAck(consumerId, ledgerId, entryId, bitSetRecyclable, ackType, validationError, properties, | ||
| txnID.getLeastSigBits(), txnID.getMostSigBits(), requestId, batchMessageId.getBatchSize()); |
Contributor
There was a problem hiding this comment.
Only the txn is not null needs to set the batch size.
added 4 commits
November 19, 2020 12:10
…ch_pendingack_modify # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now in Failover sub we ack with transaction will not get the batch size from consumer pendingAcks, so we should ack request carry the batch size.
implement
We ack with transaction will carry the bath size for individual ack delete the consumer pendingAcks.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (yes)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)