Delete explicit claim for log configuration file position in surefire…#8715
Merged
merlimat merged 1 commit intoapache:masterfrom Nov 27, 2020
Merged
Delete explicit claim for log configuration file position in surefire…#8715merlimat merged 1 commit intoapache:masterfrom
merlimat merged 1 commit intoapache:masterfrom
Conversation
… plugin Signed-off-by: Renkai <gaelookair@gmail.com>
Contributor
Author
|
/pulsarbot run-failure-checks |
lhotari
approved these changes
Nov 26, 2020
eolivelli
approved these changes
Nov 26, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this page https://logging.apache.org/log4j/2.x/manual/configuration.html said,
If we define
log4j.configurationFileexplicitly, it will become the highest priority to configure log related properties, that means any log configuration file in any module will be disabled, that will be the only active configuration file no matter we run some class or test some class in this project.But we may need different configuration file for different module, and different configuration files in main directories and test directories.
For example, I may want to put a
log4j2-test.xmlinsrc/test/resourceswith logleveldebug, which only effective when I executemvn test, but-Dlog4j.configurationFile=log4j2.xmlmake it impossible.With
-Dlog4j.configurationFile=log4j2.xmlremoved,log4j2.xmlis still the default configuration file for a module if there is no other configuration file in corresponding modules, So I think it's OK to remove a explicit define.