[MINOR] remove duplicate test case in MessageChunkingTest#9147
Merged
codelipenghui merged 1 commit intoapache:masterfrom Jan 10, 2021
Conversation
both testInvalidConfig and testInvalidUseCaseForChunking are test the same logic.
sijie
approved these changes
Jan 8, 2021
Member
|
/pulsarbot run-failure-tests |
codelipenghui
approved these changes
Jan 9, 2021
Contributor
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Jan 9, 2021
Member
|
/pulsarbot run-failure-checks |
lifepuzzlefun
deleted the
remove_duplicate_unit_test_for_invalid_chunking_config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both testInvalidConfig and testInvalidUseCaseForChunking are test the same logic.
remove testInvalidConfig
see
pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java
Line 89 in 2fd878a
and
pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java
Line 316 in 2fd878a