Skip to content

upgrade presto version to 334 for JDK 11#9178

Closed
zzzming wants to merge 1 commit intoapache:masterfrom
kafkaesque-io:presto334
Closed

upgrade presto version to 334 for JDK 11#9178
zzzming wants to merge 1 commit intoapache:masterfrom
kafkaesque-io:presto334

Conversation

@zzzming
Copy link
Contributor

@zzzming zzzming commented Jan 11, 2021

Motivation

Upgrade Presto to 334 that is required to run on JDK 11.

Modifications

Presto 334 also changes the Main class to a new package and class in a new jar, presto-server-main.jar. It has minor changes to required properties. Its dependency common-langs3 is also required to be upgraded to 3.9 to work in both JDK11.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@zzzming zzzming changed the title upgrade presto version to 334 upgrade presto version to 334 for JDK 11 Jan 11, 2021
@zzzming
Copy link
Contributor Author

zzzming commented Jan 11, 2021

I checked Presto334 is only for JDK11. I can do another PR to compile and support JDK11 with other changes. This PR will be closed.

@zzzming zzzming closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant