Skip to content

Clean up in pulsar-broker unit tests#9654

Merged
codelipenghui merged 1 commit intoapache:masterfrom
aahmed-se:unit_cleanup1
Feb 22, 2021
Merged

Clean up in pulsar-broker unit tests#9654
codelipenghui merged 1 commit intoapache:masterfrom
aahmed-se:unit_cleanup1

Conversation

@aahmed-se
Copy link
Contributor

Collection of minor cleanup in pulsar-broker unit test cases.

  • Fixing Usage of assert statements.
  • Removing unused exceptions.
  • Remove Unnecessary String creations.

@aahmed-se aahmed-se self-assigned this Feb 20, 2021
Copy link
Contributor

@vzhikserg vzhikserg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making Intellij feel happier :)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Thanks for reducing tech debt

@codelipenghui codelipenghui merged commit 22207ba into apache:master Feb 22, 2021
@aahmed-se aahmed-se deleted the unit_cleanup1 branch July 1, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments