[Doc] Add descriptions of end-to-end encryption for Python client#9707
Merged
Anonymitaet merged 4 commits intoapache:masterfrom Feb 27, 2021
Merged
[Doc] Add descriptions of end-to-end encryption for Python client#9707Anonymitaet merged 4 commits intoapache:masterfrom
Anonymitaet merged 4 commits intoapache:masterfrom
Conversation
Anonymitaet
requested review from
Huanli-Meng,
Jennifer88huang-zz,
tuteng and
zymap
zymap
approved these changes
Feb 25, 2021
zymap
added
the
doc
Huanli-Meng
reviewed
Feb 26, 2021
Contributor
Huanli-Meng
left a comment
Huanli-Meng
left a comment
There was a problem hiding this comment.
leave two minor comments. PTAL
tuteng
approved these changes
Feb 26, 2021
Co-authored-by: Huanli Meng <48120384+Huanli-Meng@users.noreply.github.com>
Co-authored-by: Huanli Meng <48120384+Huanli-Meng@users.noreply.github.com>
Member
Author
|
@Huanli-Meng thanks, I've incorporated, PTAL |
Huanli-Meng
approved these changes
Feb 26, 2021
|
|
||
| This section provides step-by-step instructions on how to use the end-to-end encryption feature in the Python client. | ||
|
|
||
| #### Prerequisite |
Contributor
There was a problem hiding this comment.
Heading is used to make the structure clear, in this case, I don't think we need a heading 4 for the prerequisite. I suggest that we use a "bold font" for prerequisite or a sentence for explain it.
|
|
||
| - Pulsar Python client 2.7.1 or later | ||
|
|
||
| #### Step |
Contributor
There was a problem hiding this comment.
Remove the heading. List the steps directly.
Contributor
Jennifer88huang-zz
left a comment
Jennifer88huang-zz
left a comment
There was a problem hiding this comment.
God job~
Left some comments.
Jennifer88huang-zz
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs for #9588