Skip to content

[Doc] Add descriptions for bookieID#9779

Merged
Anonymitaet merged 8 commits intoapache:masterfrom
Anonymitaet:0303
Mar 8, 2021
Merged

[Doc] Add descriptions for bookieID#9779
Anonymitaet merged 8 commits intoapache:masterfrom
Anonymitaet:0303

Conversation

@Anonymitaet
Copy link
Member

Add doc for #9174 and #9019

Update master doc firstly and then update 2.7.x.

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Mar 3, 2021
@Anonymitaet Anonymitaet self-assigned this Mar 3, 2021
@Anonymitaet
Copy link
Member Author

@eolivelli could you please help review? Thanks

Is the option bookieId or BookieId?

@Anonymitaet
Copy link
Member Author

@eolivelli could you please help review? Thanks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.
Overall it looks great.

I left a little suggestion

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave my comments. PTAL


# If you want to custom bookie ID or use a dynamic network address for the bookie,
# you can set this option.
# Bookie advertises itself using bookieId rather than
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Bookie advertises itself using bookieId rather than
# Bookie advertises itself using the `bookieId` rather than

@Anonymitaet Anonymitaet requested a review from Huanli-Meng March 4, 2021 11:39
@zymap
Copy link
Member

zymap commented Mar 5, 2021

/pulsarbot run-failure-checks

@Anonymitaet
Copy link
Member Author

Anonymitaet commented Mar 5, 2021

@eolivelli I've merged master and re-run the test many times but it still fails, I do not know how to deal with the test errors, could you please take a look? Many thanks!

@eolivelli
Copy link
Contributor

/pulsarbot run-failure-checks

@eolivelli
Copy link
Contributor

This change is only about docs, tests shouldn't even run

@Anonymitaet
Copy link
Member Author

@eolivelli thanks. I'm wondering that since in this PR, I also modify the bookkeeper.conf and standalone.conf files, does this (red box) affect the test?
image
If so, how about changing it to # bookieId= (add a hash mark)?

@eolivelli
Copy link
Contributor

good catch !
yes you are right!
add the '#' at the beginning of the line

@sijie sijie added this to the 2.8.0 milestone Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants