Skip to content

DISPATCH-1968: Avoid proton calls on closed raw connections#1047

Closed
ChugR wants to merge 1 commit intoapache:masterfrom
ChugR:crolke-DISPATCH-1968-2
Closed

DISPATCH-1968: Avoid proton calls on closed raw connections#1047
ChugR wants to merge 1 commit intoapache:masterfrom
ChugR:crolke-DISPATCH-1968-2

Conversation

@ChugR
Copy link
Copy Markdown
Contributor

@ChugR ChugR commented Feb 19, 2021

  • Do not write new buffers if connection is CLOSED_WRITE
  • Do not call connection_wake if CLOSED_READ or CLOSED_WRITE
    This fixes crashes but there is still work left with leaking messages and buffers when server connections close before client connections.

* Do not write new buffers if connection is CLOSED_WRITE
* Do not call connection_wake if CLOSED_READ or CLOSED_WRITE
@ChugR ChugR changed the title DISPATCH-1968: Avoid proton calls on a closed raw connections DISPATCH-1968: Avoid proton calls on closed raw connections Feb 19, 2021
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1047 (b983e61) into master (f07975e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files         111      111           
  Lines       27425    27443   +18     
=======================================
+ Hits        22621    22636   +15     
- Misses       4804     4807    +3     
Impacted Files Coverage Δ
src/adaptors/tcp_adaptor.c 3.02% <0.00%> (-0.08%) ⬇️
...re/modules/edge_addr_tracking/edge_addr_tracking.c 88.70% <0.00%> (-1.62%) ⬇️
src/router_core/connections.c 88.81% <0.00%> (-0.30%) ⬇️
src/adaptors/http1/http1_server.c 84.50% <0.00%> (-0.30%) ⬇️
src/router_core/transfer.c 92.24% <0.00%> (-0.22%) ⬇️
src/router_node.c 94.03% <0.00%> (-0.11%) ⬇️
src/message.c 87.07% <0.00%> (-0.08%) ⬇️
src/server.c 86.78% <0.00%> (+0.10%) ⬆️
src/router_core/delivery.c 93.51% <0.00%> (+0.76%) ⬆️
src/iterator.c 93.17% <0.00%> (+3.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07975e...b983e61. Read the comment docs.

Copy link
Copy Markdown
Member

@grs grs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: lgtm

@asfgit asfgit closed this in 5d27cfa Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants