DISPATCH-1968: Avoid proton calls on closed raw connections#1047
Closed
ChugR wants to merge 1 commit intoapache:masterfrom
Closed
DISPATCH-1968: Avoid proton calls on closed raw connections#1047ChugR wants to merge 1 commit intoapache:masterfrom
ChugR wants to merge 1 commit intoapache:masterfrom
Conversation
* Do not write new buffers if connection is CLOSED_WRITE * Do not call connection_wake if CLOSED_READ or CLOSED_WRITE
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 111 111
Lines 27425 27443 +18
=======================================
+ Hits 22621 22636 +15
- Misses 4804 4807 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes crashes but there is still work left with leaking messages and buffers when server connections close before client connections.