DISPATCH-583 - Fixed lifecycle management of proton links and session…#119
Closed
ganeshmurthy wants to merge 1 commit intoapache:masterfrom
Closed
DISPATCH-583 - Fixed lifecycle management of proton links and session…#119ganeshmurthy wants to merge 1 commit intoapache:masterfrom
ganeshmurthy wants to merge 1 commit intoapache:masterfrom
Conversation
…s. These are now freed after the collector is done with all the events
ted-ross
requested changes
Dec 5, 2016
Member
ted-ross
left a comment
ted-ross
left a comment
There was a problem hiding this comment.
On minor change needed (see comment). Then this is good to go.
-Ted
| * Invoke only after all proton events have been popped from the collector. | ||
| * | ||
| * @param conn The connection for which all proton events have been popped. | ||
| */ |
Member
There was a problem hiding this comment.
All of the callback's need to include the context argument (even it you don't use it in your handler).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s. These are now freed after the collector is done with all the events