Conversation
This patch makes the qd_timer_cancel() and qd_timer_free() routines block if the timer callback is currently running on another thread. This ensures that the callback is not executing when these calls return. It includes a fix to the HTTP1 adapter to avoid freeing its timer while holding the adaptor lock. This closes apache#1170 (cherry picked from commit 34b3c11) Needed by fix for blocker JIRA DISPATCH-2046
DISPATCH-1679: fix qd_connector_t leak DISPATCH-1917: fix race when accessing connector->conn_msg buffer This closes apache#1176 (cherry picked from commit 8545a42)
This closes apache#1183 (cherry picked from commit 18ac554)
kgiusti
requested review from
ChugR,
ganeshmurthy and
jiridanek
and removed request for
ChugR
Member
|
Seems like including d2f47a1 would be good to give it some chance of passing the GHA jobs if the tests pass. (I have also prodded about getting it published) |
Contributor
Author
Indeed. There are a couple of test-related patches that landed recently - I'll follow up with another PR. |
…published (apache#1169) (cherry picked from commit d2f47a1)
…nd system_tests_grpc. This closes apache#1188. (cherry picked from commit 566320a)
The command 'sudo apt-get install clang-11 llvm-11-dev' failed and exited with 100 during. This closes apache#1189. (cherry picked from commit 58f7568)
… the tests. This closes apache#1185 (cherry picked from commit 68c0836)
ganeshmurthy
approved these changes
May 6, 2021
Codecov Report
@@ Coverage Diff @@
## 1.16.x #1190 +/- ##
==========================================
- Coverage 84.79% 84.29% -0.51%
==========================================
Files 113 113
Lines 29122 27971 -1151
==========================================
- Hits 24695 23578 -1117
+ Misses 4427 4393 -34
Continue to review full report at Codecov.
|
…gh time to respond to HELLO message. This closes apache#1184. (cherry picked from commit 422666d)
…closes apache#1175. (cherry picked from commit 84186ce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.