DISPATCH-1595: Remove all python test on_modified event handlers #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4da6849)
Non-terminal dispositions were added to effect TCP adaptor flow control in the 1.16 release. Scraper needs adjustments to handle them. * Report negative disposition delta times as 0 seconds * Allow non-terminal dispositions to be overwritten without logging an error
and not on the core thread. Move flush_outgoing_bufs call to handle_disconnected function. This closes apache#1174 (cherry picked from commit 18bce61)
When TCP adaptor receives an EOS in the incoming streaming link then it calls pn_raw_write_close to the corresponding PN raw connection. This sends a FIN to the raw connection peer. If the adaptor then continues to honor the RX window closure then it never reads data from the raw connection that now has a close in progress. Further, when the incoming TCP window is full then the raw connection never returns the client's FIN and the connection is stuck open. This patch causes the adaptor to override backpressure flow control and to keep reading from a raw connection after a write_close has been effected. This closes apache#1177 (cherry picked from commit 7ef0a0f)
(cherry picked from commit fb3ebad)
This patch makes the qd_timer_cancel() and qd_timer_free() routines block if the timer callback is currently running on another thread. This ensures that the callback is not executing when these calls return. It includes a fix to the HTTP1 adapter to avoid freeing its timer while holding the adaptor lock. This closes apache#1170 (cherry picked from commit 34b3c11) Needed by fix for blocker JIRA DISPATCH-2046
DISPATCH-1679: fix qd_connector_t leak DISPATCH-1917: fix race when accessing connector->conn_msg buffer This closes apache#1176 (cherry picked from commit 8545a42)
This closes apache#1183 (cherry picked from commit 18ac554)
…published (apache#1169) (cherry picked from commit d2f47a1)
…nd system_tests_grpc. This closes apache#1188. (cherry picked from commit 566320a)
The command 'sudo apt-get install clang-11 llvm-11-dev' failed and exited with 100 during. This closes apache#1189. (cherry picked from commit 58f7568)
… the tests. This closes apache#1185 (cherry picked from commit 68c0836)
…gh time to respond to HELLO message. This closes apache#1184. (cherry picked from commit 422666d)
…closes apache#1175. (cherry picked from commit 84186ce)
There is no on_modified event in proton python MessagingHandler. Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling and delivers both states in the on_released handler. This patch makes the dispatch handler model precisely reflect the proton handler model.
Contributor
Author
|
Whoops. bad pr for sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no on_modified event in proton python MessagingHandler.
Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling
and delivers both states in the on_released handler.
This patch makes the dispatch handler model precisely reflect the
proton handler model.