DISPATCH-2247: Added router id to log message#1414
Merged
asfgit merged 1 commit intoapache:mainfrom Nov 1, 2021
Merged
Conversation
ganeshmurthy
force-pushed
the
DISPATCH-2247
branch
from
b0851ab to
870dbff
Compare
ted-ross
reviewed
Nov 1, 2021
| // which will help us in debugging. | ||
| // | ||
| char *r_id = 0; | ||
| bool free_rid = false; |
Member
There was a problem hiding this comment.
You don't need the free_rid thing. It is safe to call 'free' on a null pointer.
ted-ross
reviewed
Nov 1, 2021
| free_rid = true; | ||
| } | ||
| } | ||
| qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown router with router id %s", r_id); |
Member
There was a problem hiding this comment.
There is a similar log for MAR messages. For completeness, you should probably add the router_id to that one too.
ganeshmurthy
force-pushed
the
DISPATCH-2247
branch
from
870dbff to
a7a9110
Compare
ganeshmurthy
force-pushed
the
DISPATCH-2247
branch
from
a7a9110 to
5804a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.