DISPATH-2298: Avoid rescheduling qd_timer if we are already servicing timer #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshmurthy
approved these changes
Dec 13, 2021
kgiusti
approved these changes
Dec 14, 2021
Contributor
kgiusti
left a comment
kgiusti
left a comment
There was a problem hiding this comment.
A nice clean optimization - well done!
Please fix typo in commit log "DISPATH" before commit.
Let's hold off committing this for now - until we stabilize the CI a bit. I don't think this patch is the cause of the failures on CI btw.
…g timer If we are in the middle of running through the list of timers in qd_timer_visit() we don't need to wake the timer as anything we add to the list will get serviced immediately in any case.
astitcher
force-pushed
the
dispatch-2298
branch
from
1d06b2c to
4343979
Compare
Member
Author
|
Fixed the commit message typo |
Member
Author
|
Rebase and merged to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are in the middle of running through the list of timers in
qd_timer_visit() we don't need to wake the timer as anything we add to
the list will get serviced immediately in any case.