DISPATCH-760: Message annotation handling improvements#171
Closed
ChugR wants to merge 9 commits intoapache:masterfrom
Closed
DISPATCH-760: Message annotation handling improvements#171ChugR wants to merge 9 commits intoapache:masterfrom
ChugR wants to merge 9 commits intoapache:masterfrom
Conversation
added 9 commits
June 30, 2017 11:04
Get rid of is_interrouter flag in favor of existing strip_annotations flags. Pass strip_annotations_in through message to parse function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces existing annotation handling with a more efficient version. It is fully compatible with 0.8.x.
A comparison with 0.8.x has run on a single laptop. A sender sends a short message with a varying number of 10-byte user annotations to an ingress router A. Router A sends the messages to egress router B. A single client is attached to router B. This comparison is not rigorous and at the 50-annotation-per-message level the producer started to be the limiting factor.
Messages per second. Number of annotations, Nanno, vs router code version, 0.8.x or new.