Conversation
Add missing frees in tests.
Maybe not a leak in a deployed broker but fixed it anyway to keep tests clean.
Changed server shutdown order so that context objects are not used after free by logger.
Contributor
|
This looks good to me. I will commit. |
ChugR
pushed a commit
to ChugR/qpid-dispatch
that referenced
this pull request
Oct 13, 2022
Co-authored-by: mgoulish <mgoulish@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are fixes for valgrind errors in the unit tests that I saw when running tests on master. There are more to fix, in the system tests.
Requesting review as I have been away from dispatch for a while, don't want to cause a regression. ctest with my changes is no worse than without - the policy and user_id_proxy system tests are failing with timeouts for me on master with/without these changes.