Closed
Conversation
- upgrade connection failure INFO messages to WARNING - downgrade incref/decref messages to TRACE Personally I think the incref/decref messages should not be in user-facing logs at all, but if they must be they should be TRACE as they occur at a per-delivery (i.e. per-message) volume.
…ection Incoming connection establishment was being logged at info. Added info logs for outgoing connection establishment and any connection close.
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 86.56% 86.59% +0.02%
==========================================
Files 69 69
Lines 15467 15471 +4
==========================================
+ Hits 13389 13397 +8
+ Misses 2078 2074 -4
Continue to review full report at Codecov.
|
ted-ross
reviewed
Jun 27, 2018
|
|
||
| qd_log(ctx->server->log_source, QD_LOG_INFO, "Accepted connection to %s from %s", | ||
| name, ctx->rhost_port); | ||
| qd_log(ctx->server->log_source, QD_LOG_INFO, |
Member
There was a problem hiding this comment.
There appear to be more arguments than format directives in this call.
Why did you remove the information about the remote host?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes to dispatch logging based on experience debugging the HTTP Envoy bridge.
See the commit comments for explanation.
One additional question: I was confused by the new messageLoggingComponents config, when I set MESSAGE enable trace+ I saw nothing at all, which was surprising. Perhaps the default should be "all" so that enabling MESSAGE trace does what folks expect and they can turn the logging down per connector/listener if they wish. Since trace logging will be off in production (I hope!) this won't have any effect except on users that are deliberately debugging AND have turned on trace logging for at least the MESSAGE module, so are expecting a lot of log data.