This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Dispatch 1046 - fix policy handling in python3 environment#334
Closed
kgiusti wants to merge 2 commits into
Closed
Conversation
Contributor
|
This patch fixes the c_char_p in py3 and improves interfaces with some const additions. The patch also repairs some incorrect handling of policy's parse tree. It looks like there were resource leaks when the trees were deleted. I don't think that was just a py3 issue. This PR looks OK to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to change the way we pass args to the host address parse tree api under python3
c_char_p is a bytes type under python3. Passing and returning a unicode string causes it to fail. Had to manually convert between the two. Also need to save a copy of the pattern in the tree as a payload.