This repository was archived by the owner on Apr 15, 2026. It is now read-only.
Dispatch-1055: Router fails to propagage credit on link route after drain cycle#340
Closed
ChugR wants to merge 3 commits into
Closed
Dispatch-1055: Router fails to propagage credit on link route after drain cycle#340ChugR wants to merge 3 commits into
ChugR wants to merge 3 commits into
Conversation
added 3 commits
July 9, 2018 16:25
The test is run first without a link route to observe that it works. Then it is run with the link route and hangs.
Reset incremental credit given to core at end of drain cycle. Fix logic computing drain_changed flag.
ganeshmurthy
approved these changes
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR the "fix" is all in transfer.c.
The commit also adds a test that works when not in link route and fails in a link route.