Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

Dispatch-1055: Router fails to propagage credit on link route after drain cycle#340

Closed
ChugR wants to merge 3 commits into
apache:masterfrom
ChugR:DISPATCH-1055-2
Closed

Dispatch-1055: Router fails to propagage credit on link route after drain cycle#340
ChugR wants to merge 3 commits into
apache:masterfrom
ChugR:DISPATCH-1055-2

Conversation

@ChugR
Copy link
Copy Markdown
Contributor

@ChugR ChugR commented Jul 9, 2018

In this PR the "fix" is all in transfer.c.

  • The router was not accounting for transfers that never arrive when drain consumes the credit without sending messages. The fix is to reset the internal credit counts when a drain cycle ends.
  • The router calculates if drain changed more correctly.

The commit also adds a test that works when not in link route and fails in a link route.

Chuck Rolke added 3 commits July 9, 2018 16:25
The test is run first without a link route to observe that it works.
Then it is run with the link route and hangs.
Reset incremental credit given to core at end of drain cycle.
Fix logic computing drain_changed flag.
@ChugR ChugR changed the title Dispatch-1055: Router fails to propagage credit on link router after drain cycle Dispatch-1055: Router fails to propagage credit on link route after drain cycle Jul 10, 2018
@asfgit asfgit closed this in a6c4b94 Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants