Skip to content
This repository was archived by the owner on Apr 15, 2026. It is now read-only.

DISPATCH-1150: Router core messaging client#394

Closed
kgiusti wants to merge 1 commit into
apache:masterfrom
kgiusti:DISPATCH-1150
Closed

DISPATCH-1150: Router core messaging client#394
kgiusti wants to merge 1 commit into
apache:masterfrom
kgiusti:DISPATCH-1150

Conversation

@kgiusti
Copy link
Copy Markdown
Contributor

@kgiusti kgiusti commented Oct 23, 2018

No description provided.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #394 into master will increase coverage by 0.08%.
The diff coverage is 88.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   84.98%   85.07%   +0.08%     
==========================================
  Files          76       77       +1     
  Lines       16817    17170     +353     
==========================================
+ Hits        14292    14607     +315     
- Misses       2525     2563      +38
Impacted Files Coverage Δ
src/message.c 88.86% <100%> (+0.17%) ⬆️
src/router_core/core_client_api.c 85.21% <85.21%> (ø)
...c/router_core/modules/test_hooks/core_test_hooks.c 91.93% <94.73%> (+1.02%) ⬆️
src/router_core/forwarder.c 93.25% <0%> (-0.73%) ⬇️
src/router_node.c 93.52% <0%> (-0.39%) ⬇️
src/router_core/route_tables.c 76.54% <0%> (-0.26%) ⬇️
src/parse.c 85.52% <0%> (+0.26%) ⬆️
src/router_core/connections.c 95.37% <0%> (+0.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267207d...729ed4c. Read the comment docs.

* @return zero on success.
*/
int qdrc_client_request_CT(qdrc_client_t *client,
uintptr_t request_context,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the context not a void* ?

@asfgit asfgit closed this in 8a93f7c Oct 26, 2018
@kgiusti kgiusti deleted the DISPATCH-1150 branch October 26, 2018 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants