DISPATCH-974 - Added code to qdstat and qdmanage clients to repeatedl…

[ganeshmurthy]

…y get rows to overcome the limitations imposed by PROTON-1846

[ChugR]

+1 the implementation looks OK and the tests pass.
The technique used here, pulling successive slices on repeated calls, leaves room for the underlying list in proton to change between calls. This could lead to duplicate or missing entries. Is there a place to put doc text explaining this so that users' expectations are properly framed when the lists are longer than the 700 entries?

[kgiusti]

You might consider using a map indexed by entity id here as a way to filter out duplicates.

[ganeshmurthy]

I discussed this with @ted-ross . The new entries to the linked list are added at the tail. So no need to remove duplicates. It might show stale data but so does the previous approach

[kgiusti]

1

[codecov-io]

Codecov Report

Merging #503 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   86.96%   86.93%   -0.04%     
==========================================
  Files          87       87              
  Lines       19313    19314       +1     
==========================================
- Hits        16795    16790       -5     
- Misses       2518     2524       +6

Impacted Files	Coverage Δ
src/router_core/transfer.c	93.64% <0%> (-0.83%)	⬇️
src/parse.c	87.9% <0%> (-0.26%)	⬇️
src/router_core/route_tables.c	76.67% <0%> (-0.25%)	⬇️
src/router_node.c	93.69% <0%> (-0.24%)	⬇️
src/router_core/router_core.c	86.48% <0%> (-0.22%)	⬇️
src/router_core/agent_link.c	67.52% <0%> (ø)	⬆️
src/router_core/management_agent.c	98.52% <0%> (+0.49%)	⬆️
src/router_core/agent_address.c	90.24% <0%> (+0.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbb4c5...1864812. Read the comment docs.