DISPATCH-1467: enable AddressSanitizer build option (ASAN) #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 86.44% 86.47% +0.03%
==========================================
Files 91 91
Lines 20622 20618 -4
==========================================
+ Hits 17826 17830 +4
+ Misses 2796 2788 -8
Continue to review full report at Codecov.
|
|
I didn't notice the GH mention before. I read through the PR diff. I'll now try compiling and running with GCC and Clang. |
|
When compiling and running tests with gcc, with libwebsocket available, I got this crash in test 9 and in other tests which don't readily print these messages, and in test 19 which prints it. After that I killed ctest. When compiled without libwebsocket, I get clean result, except for system_tests_console. That probably should not run, when I don't have libwebsockets? The libwebsocket failConsole test fail |
|
With Clang, dispatch failed to link. I think this is because of |
|
Ok, it is the tsan change. http://clang.llvm.org/docs/AddressSanitizer.html mentions that the shared asan library will not link when -Wl,-z,defs is used. BeforeLines 213 to 215 in bd471c1 Nowqpid-dispatch/src/CMakeLists.txt Lines 145 to 149 in f03308c |
kgiusti
force-pushed
the
DISPATCH-1467
branch
from
246f80c to
1400707
Compare
Contributor
Author
The libwebsockets issue is known - there's some sort of illegal memory bug in certain versions of libwebsockets: |
Contributor
Author
|
@jdanekrh - thanks for the review. I've run the patch on Ubuntu 18.04 and 16.04 and have just pushed an update to the suppression files. I've also enabled ASAN checking on one of the travis builds and am testing that now. |
kgiusti
added a commit
to kgiusti/dispatch
that referenced
this pull request
Nov 4, 2019
To run the AddressSanitizer, define RUNTIME_CHECK=asan via CMake: cmake .. -DRUNTIME_CHECK=asan This patch updates the .travis.yml file to enable address and undefined behavior checking. Also included are minor code tweaks to issues found when running with the sanitizer enabled. This closes apache#608
kgiusti
force-pushed
the
DISPATCH-1467
branch
from
1400707 to
c5dddd8
Compare
Contributor
Author
|
Ok, this patch now passes travis so it's ready for review. |
jirkadanek
approved these changes
Nov 4, 2019
jirkadanek
reviewed
Nov 4, 2019
README
Outdated
| This option turns on extra run time memory verification, including | ||
| leak checks. | ||
|
|
||
| Applicable only to GCC versions >= 7.4 and Clang versions >= 6.0. |
There was a problem hiding this comment.
Suggested change
| Applicable only to GCC versions >= 7.4 and Clang versions >= 6.0. | |
| Applicable only to GCC versions >= 5.4 and Clang versions >= 6.0. |
Contributor
Author
There was a problem hiding this comment.
Good catch will update thanks.
ganeshmurthy
reviewed
Nov 4, 2019
| getcwd_error = 1; | ||
| break; | ||
| if (errno != ERANGE) { | ||
| // Hard failure - can't recover from this |
Contributor
There was a problem hiding this comment.
This change does not seem particularly related to this PR. Or is it? If not, can we make this change in a different commit ?
Contributor
Author
There was a problem hiding this comment.
It is related - the address sanitizer threw a fit on that section of the code - detected a possible buffer overflow. That change is the fix.
ganeshmurthy
approved these changes
Nov 4, 2019
To run the AddressSanitizer, define RUNTIME_CHECK=asan via CMake: cmake .. -DRUNTIME_CHECK=asan This patch updates the .travis.yml file to enable address and undefined behavior checking. Also included are minor code tweaks to issues found when running with the sanitizer enabled. This closes apache#608
kgiusti
force-pushed
the
DISPATCH-1467
branch
from
c5dddd8 to
1c2917d
Compare
ChugR
pushed a commit
to ChugR/qpid-dispatch
that referenced
this pull request
Oct 13, 2022
Delete the pseudo egress dispatch connection in the same manner as a true tcp connection rather than on a timer thread. Use exact data lengths to verify the TCP counter values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the AddressSanitizer, define RUNTIME_CHECK=asan via CMake:
cmake .. -DRUNTIME_CHECK=asan
This patch includes minor code tweaks to issues found when running
with the sanitizer enabled.