DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery …#658
Closed
ganeshmurthy wants to merge 2 commits intoapache:masterfrom
Closed
DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery …#658ganeshmurthy wants to merge 2 commits intoapache:masterfrom
ganeshmurthy wants to merge 2 commits intoapache:masterfrom
Conversation
…and its peers on large streaming messages. This will allow the presettled counters to be updated correctly
kgiusti
reviewed
Jan 13, 2020
…ed flag on the delivery inside core thread to avoid contention. Also added some comments
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 86.53% 86.57% +0.03%
==========================================
Files 91 91
Lines 20652 20658 +6
==========================================
+ Hits 17872 17884 +12
+ Misses 2780 2774 -6
Continue to review full report at Codecov.
|
kgiusti
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and its peers on large streaming messages. This will allow the presettled counters to be updated correctly