Added debug-dump backtrace for leaked objects in pooled memory.#711
Merged
ted-ross merged 3 commits intoapache:masterfrom Mar 30, 2020
Merged
Added debug-dump backtrace for leaked objects in pooled memory.#711ted-ross merged 3 commits intoapache:masterfrom
ted-ross merged 3 commits intoapache:masterfrom
Conversation
kgiusti
reviewed
Mar 27, 2020
kgiusti
approved these changes
Mar 27, 2020
Contributor
kgiusti
left a comment
kgiusti
left a comment
There was a problem hiding this comment.
This looks good to me. The symbol backtrace may need to be freed else ASAN could trigger - see inline.
Contributor
|
It would also be valuable to have a timestamp on the allocation. Then it could be correlated with the log file accurately. |
Contributor
|
Please correct me if I am wrong here. If I set the debugDumpFile attribute of router entity and have QD_MEMORY_STATS as ON and run the system_tests_one_router, I see the following on stdout 20: Router QDR debug dump file: It would be useful for me to see the alloaction backtrace of all the above 14 qd_policy_settings_t in the debugDumpFile, right ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If QD_MEMORY_DEBUG is defined, this stores a backtrace for each allocated pool object so that objects left unfreed can be better described at shutdown.
This is a fairly expensive feature. We may want to consider providing an extra definable option so we can use QD_MEMORY_DEBUG without using this new feature.