Dispatch 1708 Fallback dest test_28 receives phase 0 messages on fallback link. #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ted-ross
reviewed
Jul 13, 2020
| cls.routers[0].wait_router_connected('INT.B') | ||
| cls.routers[1].wait_router_connected('INT.A') | ||
|
|
||
| cls.ROUTER_INTA = cls.routers[0].addresses[0] |
Member
There was a problem hiding this comment.
Nice! This is a major improvement.
Add count of those released messages. Note that this commit reveals another issue where test_28 fails hard with message: 63: AssertionError: None != 'Timeout Expired - n_tx=256, n_rx=0, n_rel=111117, phase=1, local_rel=1246' With this error router EA1 is never notified of the primary receiver on EB1 going away.
ted-ross
approved these changes
Jul 22, 2020
ChugR
pushed a commit
to ChugR/qpid-dispatch
that referenced
this pull request
Oct 13, 2022
…ystem … (apache#775) * Fixes apache#567: Modified TCP adaptor to use the qd TLS API. Added system tests to test TLS over TCP. * Code review changes: Call qd_adaptor_buffers_copy_to_qd_buffers from the tcp_adaptor.c instead of duplicating code. Also remove a comment from a test * clang-format fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't commit this until the bug[1] is fixed.
This PR releases phase 0 messages received on fallback link.
This PR also includes housekeeping changes:
[1] with this patch test_28 fails hard with EA1 never getting notified of the loss of the primary receiver on EB1.