DISPATCH-401 - Verified host name by default and added a --no-verify-…#83
Closed
ganeshmurthy wants to merge 1 commit intoapache:masterfrom
Closed
DISPATCH-401 - Verified host name by default and added a --no-verify-…#83ganeshmurthy wants to merge 1 commit intoapache:masterfrom
ganeshmurthy wants to merge 1 commit intoapache:masterfrom
Conversation
…host-name to disable host name verification
| help="Trusted Certificate Authority Database file (PEM Format)") | ||
| group.add_option("--ssl-password", action="store", type="string", metavar="PASSWORD", | ||
| help="Certificate password, will be prompted if not specifed.") | ||
| group.add_option("--no-verify-host-name", action="store_true", default=False, |
Contributor
There was a problem hiding this comment.
I'd suggest: --verify-peer-name type=bool, default=true. Bool options with negative names are confusing and "host" is a bit vague - peer is more clearly the other host. Also the help text is very long, maybe "Verify the peer host name matches the certificate. Default true, setting to false is insecure ."
Member
There was a problem hiding this comment.
Maybe add 'ssl' to the option also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…host-name to disable host name verification