Skip to content

Conversation

@mibo
Copy link
Contributor

@mibo mibo commented Mar 29, 2018

No description provided.

@tabish121
Copy link
Contributor

I believe the correct fix is to call PropertyUtil.parseQuery(remoteURI) instead and it will do the right thing, although we can't know until you provide some tests to validate it.

@mibo
Copy link
Contributor Author

mibo commented Apr 2, 2018

I agree that using PropertyUtil.parseQuery(remoteURI) would be better (which then does the PropertyUtil.parseQuery(uri.getRawQuery()) call after a null check).
I will change it and add the currently missing (JUnit) tests.
But I think we can agree that using PropertyUtil.parseQuery(remoteURI.getQuery()) is a bug.

Btw. I oriented the fix by the TransportFactory.

@mibo
Copy link
Contributor Author

mibo commented Apr 4, 2018

Changed to use PropertyUtil.parseQuery(remoteURI) and added tests.

@tabish121
Copy link
Contributor

You need to squash the commits and force push so that it is contained in one commit, thanks.

@asfgit asfgit merged commit b96f4f2 into apache:master Apr 5, 2018
asfgit pushed a commit that referenced this pull request Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants