RANGER-5657: Limit getAllModuleNames() to sys-admin sessions in SessionMgr#1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of 0274a6a0 / #1036 to
ranger-2.9.Follow-up fix for RANGER-5627. RANGER-5627 changed
SessionMgr.resetUserModulePermission()to grant all UI modules whenisUserAdmin() || isKeyAdmin(). That incorrectly gives DB key-admin users the full module list (including Security Zone) viagetAllModuleNames().Fix: use
getAllModuleNames()only whenuserSession.isUserAdmin(). Config super-users are unaffected (they already get full admin throughsuperUser→isUserAdmin()).Fixes RANGER-5657.
Test plan
mvn test -pl security-admin -Dtest=TestSessionMgr,TestRangerSuperUserConfig -Drat.skip=true -Dcheckstyle.skip=true -Dpmd.skip=true -Dspotbugs.skip=trueMade with Cursor