RANGER-3763:The max limit of the requested entities is not configurable in tagsync #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
approved these changes
May 18, 2022
| private static final String TAGSYNC_SINK_MAX_BATCH_SIZE_PROP = "ranger.tagsync.dest.ranger.max.batch.size"; | ||
|
|
||
|
|
||
| private static final String TAGSYNC_ATLAS_REST_SOURCE_REQUESTED_ENTITIES_LIMIT_MAX = "ranger.tagsync.source.atlasrest.requested.entities.limit.max"; |
Contributor
There was a problem hiding this comment.
I suggest to rename the property to: ranger.tagsync.source.atlasrest.entities.batch.size
Contributor
Author
There was a problem hiding this comment.
Thanks for your help
Contributor
|
Fix is now committed in master branch. Thanks @Hoo199212 for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the configuration problem of the max limit of the requested entities