Skip to content

RANGER-4239: Upgrade Trino version to 410 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiaoqingbo wants to merge 1 commit into from
Closed

RANGER-4239: Upgrade Trino version to 410 #257

jiaoqingbo wants to merge 1 commit into from

Conversation

@jiaoqingbo
Copy link

@jiaoqingbo jiaoqingbo commented May 16, 2023 •
edited
Loading

What changes were proposed in this pull request?

upgrade trino version from 377 to 410

How was this patch tested?

manual tests

@jiaoqingbo jiaoqingbo closed this May 16, 2023
kar0t
kar0t reviewed Jun 13, 2023
View reviewed changes
...rc/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
}

@Override
public Optional<ViewExpression> getRowFilter(SystemSecurityContext context, CatalogSchemaTableName tableName) {
Copy link

@kar0t kar0t Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @jiaoqingbo I have a question. Why did you remove this function to make ranger plugin work w/ Trino 410+?

Thanks.

@Yiutto
Copy link

Yiutto commented Jul 27, 2023

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-trino-plugin: Compilation failure: Compilation failure:
[ERROR] /home/trino/ranger-release-ranger-2.3.0/plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:[159,2] error: method does not override or implement a method from a supertype
[ERROR] /home/trino/ranger-release-ranger-2.3.0/plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java:[350,2] error: method does not override or implement a method from a supertype
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-trino-plugin: Compilation failure
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:375)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)

trino-420 (jdk17),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kar0t kar0t kar0t left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiaoqingbo @Yiutto @kar0t