RANGER-5477: Fix TransformerFactory incompatibility causing plugin installation failures #842
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch fixes a Ranger plugin installation failure caused by applying unsupported SAX parser features to TransformerFactory in XmlConfigChanger.
The existing implementation attempted to enforce XML security using setFeature(), which is not supported by TransformerFactory and resulted in TransformerConfigurationException during plugin setup.
The fix replaces the incompatible setFeature() calls with the supported JAXP mechanism using setAttribute() (ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_STYLESHEET) to restrict external entity access during XML transformation.
This maintains the intended XXE protection while ensuring compatibility across JDK versions and TransformerFactory implementations.
How was this patch tested?
Confirmed no TransformerConfigurationException is thrown during plugin setup.
Confirmed plugin properties are added while preserving existing configuration.
Verified successful using: mvn clean compile package install.