RANGER-5602: Local build failure due to unit test failure in TestPolicyACLs#950
Open
vyommani wants to merge 1 commit into
Open
RANGER-5602: Local build failure due to unit test failure in TestPolicyACLs#950vyommani wants to merge 1 commit into
vyommani wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switched Delegate from lazy computeIfAbsent to eager initialization in the constructor. All internal maps are now fully populated and wrapped with unmodifiableMap before the Delegate is published to the cache.
This eliminates the CME because HashMap.get() is thread-safe for concurrent reads when there are no writes. The previous computeIfAbsent caused concurrent writes on a shared HashMap when multiple threads accessed the same cached Delegate, which parallelStream exposed
How was this patch tested?
after fix mvn test -Dtest=TestPolicyACLs#testResourceACLs_dataMask is passing.