Skip to content

RATIS-2586. zizmor check should reflect failure in fork#138

Merged
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:RATIS-2586
Jul 2, 2026
Merged

RATIS-2586. zizmor check should reflect failure in fork#138
adoroszlai merged 2 commits into
apache:masterfrom
adoroszlai:RATIS-2586

Conversation

@adoroszlai

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

zizmor workflow added in RATIS-2493 provides feedback via "Code scanning results". The workflow itself passes even if it finds issues to be fixed. This does not work well in forks where code scanning is disabled.

To provide better feedback, the workflow should reflect scan results in forks.

Also:

  • skip zizmor check for changes that do not touch workflows
  • cancel run for obsolete commit (if new commit is pushed to the branch, but only in forks/PR)

https://issues.apache.org/jira/browse/RATIS-2586

How was this patch tested?

Tested the same in apache/ozone:

Without the patch passes despite intentional violation:
https://github.com/adoroszlai/ozone/actions/runs/28570405264/job/84706670204#step:3:1058

Same violation with the patch fails:
https://github.com/adoroszlai/ozone/actions/runs/28570585965/job/84707233189#step:3:208

The patch without intentional violation passes (also in this repo):
https://github.com/adoroszlai/ozone/actions/runs/28570809169/job/84707932173#step:3:107
https://github.com/adoroszlai/ratis-thirdparty/actions/runs/28613321819

@adoroszlai adoroszlai self-assigned this Jul 2, 2026

@szetszwo szetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 03d3cc4 into apache:master Jul 2, 2026
5 checks passed
@adoroszlai adoroszlai deleted the RATIS-2586 branch July 2, 2026 19:52
@adoroszlai

Copy link
Copy Markdown
Contributor Author

Thanks @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants