RATIS-2035. Refactor streaming code for Read.#1046
Merged
adoroszlai merged 5 commits intoapache:masterfrom Mar 7, 2024
Merged
Conversation
| */ | ||
| public interface DataStreamServerRpc extends ServerRpc, RaftPeer.Add, Closeable { | ||
| @Override | ||
| void start(); |
Contributor
There was a problem hiding this comment.
Do we need to keep this function as ServerRpc already has one?
Contributor
Author
There was a problem hiding this comment.
You are right that we can remove it, although this signature in this one is different -- it does not throws IOException.
OneSizeFitsQuorum
approved these changes
Mar 2, 2024
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
LGTM~
The code becomes much clearer ~
adoroszlai
approved these changes
Mar 7, 2024
Contributor
|
Thanks @szetszwo for the patch, @OneSizeFitsQuorum for the review. |
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing and merging this! |
Contributor
Author
|
@OneSizeFitsQuorum , thank you also for reviewing this! |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 9, 2024
szetszwo
added a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RATIS-2035