RATIS-2288. Add some assertions to RaftServerImpl to improve robustness #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
May 8, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@jianghuazhu , thanks for working on this!
This change is really minor. How about we combine it with some other changes such as RATIS-2180? Otherwise, it won't be scale.
| break; | ||
| case STATEMACHINELOGENTRY: | ||
| TransactionContext trx = getTransactionContext(next, true); | ||
| Preconditions.assertNotNull(trx, "trx"); |
Contributor
There was a problem hiding this comment.
Let's use
Objects.requireNonNull(trx, "trx == null");We added it for the pre Java 7 JDK.
Contributor
Author
There was a problem hiding this comment.
Thanks @Szeto for the comment and review.
I will fix this in RATIS-2180.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When executing RaftServerImpl#getTransactionContext(), it may return null. We should add some assertions.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2288
How was this patch tested?
ci:
https://github.com/jianghuazhu/ratis/actions/runs/14897497515