RATIS-2469. Remove Command#close()#1404
Merged
adoroszlai merged 1 commit intoapache:masterfrom Mar 29, 2026
Merged
Conversation
szetszwo
approved these changes
Mar 28, 2026
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AbstractShell#close()is never called, thus neither isCommand#close()Command#close().Context#close()is only used to closePrintStream, which should be the responsibility of the creator ofContext.System.outdoes not need to be closed.Let's remove these unused and useless
close()methods.https://issues.apache.org/jira/browse/RATIS-2469
How was this patch tested?
https://github.com/adoroszlai/ratis/actions/runs/23693045561