RATIS-2537. Support configurable gRPC TLS provider and cipher suites#1462
Open
HTHou wants to merge 3 commits into
Open
RATIS-2537. Support configurable gRPC TLS provider and cipher suites#1462HTHou wants to merge 3 commits into
HTHou wants to merge 3 commits into
Conversation
HTHou
force-pushed
the
RATIS-2537-configurable-grpc-tls
branch
from
beff449 to
f2202f1
Compare
HTHou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This patch makes gRPC TLS settings configurable through
RaftProperties:It also allows generic JSSE providers, such as KonaSSL, to be used with Netty's JDK
SslContextpath and ALPNh2.Why
Ratis currently hardcodes most gRPC TLS behavior around Netty's defaults. Deployments that need custom JSSE providers or non-default protocol/cipher suites cannot configure them without code changes.
Validation
./mvnw -pl ratis-grpc -Dtest=TestGrpcTlsConfig test ./mvnw -pl ratis-grpc checkstyle:check ./mvnw -pl ratis-grpc install -DskipTestsI also ran a local KonaSSL smoke test with
TLCPv1.1,TLCP_ECC_SM4_GCM_SM3, and ALPNh2.